-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade WaterDog to v2 #1210
Draft
derklaro
wants to merge
6
commits into
nightly
Choose a base branch
from
waterdog2
base: nightly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
This pull should be included in the 4.0 release
in: node
An issue/pull request releated to the node module code
t: platform
Request to add/change a platform implementation
in: module
An issue/pull request releated to one of the internal modules
labels
Apr 23, 2023
Test Results 47 files ±0 47 suites ±0 1m 27s ⏱️ +14s Results for commit 88aefb1. ± Comparison against base commit 36be7e0. This pull request removes 15 and adds 15 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: module
An issue/pull request releated to one of the internal modules
in: node
An issue/pull request releated to the node module code
t: platform
Request to add/change a platform implementation
v: 4.X
This pull should be included in the 4.0 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
WaterdogPE version 2 was released and we should upgrade to this new version as the 1.X will no longer receive updates.
Modification
Update usages of Waterdog classes from 1.X to 2.X & update configuration file.
Result
Waterdog v2 can now be used with CloudNet.
Other Context