Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactore(add store) #125

Merged
merged 31 commits into from
Apr 5, 2024
Merged

refactore(add store) #125

merged 31 commits into from
Apr 5, 2024

Conversation

ChrOertlin
Copy link
Contributor

@ChrOertlin ChrOertlin commented Apr 4, 2024 •
edited
Loading

Added

adds a store to the genotype api.

Database is now initialised on startup and sessions are closed on app shutdown.

Also migrated to pydantic v2 in one go, i..e this closes #84, #94

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner April 4, 2024 14:10
diitaz93
diitaz93 approved these changes Apr 5, 2024
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

genotype_api/services/endpoint_services/sample_service.py Outdated Show resolved Hide resolved
genotype_api/services/endpoint_services/sample_service.py Outdated Show resolved Hide resolved
genotype_api/database/crud/read.py Show resolved Hide resolved
@ChrOertlin
Copy link
Contributor Author

tests

Database connection via the swagger works - added a test user
image

@ChrOertlin
Copy link
Contributor Author

plates view works:

image

@ChrOertlin
Copy link
Contributor Author

Specific plate view works:

image

@ChrOertlin
Copy link
Contributor Author

ChrOertlin commented Apr 5, 2024 •
edited
Loading

matches to work same results as latest:

image

@ChrOertlin
Copy link
Contributor Author

read snps works

image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChrOertlin ChrOertlin merged commit fce6f11 into main Apr 5, 2024
3 checks passed
@ChrOertlin ChrOertlin deleted the remove-sqlmodel branch April 5, 2024 13:51
@ChrOertlin ChrOertlin mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Pydantic to version 2
2 participants
@ChrOertlin @diitaz93