-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend bedfiles for CNV analysis #1469
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## update_cnvkit_pons #1469 +/- ##
=====================================================
Coverage ? 99.48%
=====================================================
Files ? 40
Lines ? 1960
Branches ? 0
=====================================================
Hits ? 1950
Misses ? 10
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
As a note! I wonder if we could skip the workflow integrity checks in this PR since it is a nested PR which I plan to test more thoroughly in the add CNVkit to GENS PR #1448 since that is where I have access to a better way of interpreting the results. So I was thinking I could run all of my tests there. Additionally all PRs will eventually end up in the #1358 PR which I will run some final tests on when everything has been merged. So we're pretty far from the develop branch |
Quality Gate passedIssues Measures |
Description
During the work introducing GENS for TGA it was discovered that about half of all regions in the bedfile for GMCKsolid 4.1 was discarded by CNVkit during analysis. This was due to small regions in the bedfile, see issue: #1468
To fix this it was initially planned to update the bedfiles in the target capture repo: https://github.com/Clinical-Genomics/target_capture_bed/issues/133 however there was no easy solution to implement this alternate versions of the bedfiles, and in the end the best way to solve the issue seems to be to extend these short regions dynamically during runtime specifically for the CNV analysis.
This also has the benefit of leaving the SNV and InDel calling, and the QC metrics unchanged.
To achieve this a new rule was added with a extend bed-regions step, followed by bedtools sort and merge to merge potentially overlapping bed regions after the extension.
Added
Changed
Fixed
Removed
Documentation
Tests
Feature Tests
Pipeline Integrity Tests
.hk
file)Clinical Genomics Stockholm
Documentation
Panel of Normal specific criteria
User Changes
Infrastructure Changes
Checklist
Important
Ensure that all checkboxes below are ticked before merging.
For Developers
For Reviewers
conditions where applicable, with satisfactory results.