-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Addon API documentation : Add test environment details #337
base: main
Are you sure you want to change the base?
Conversation
Deployment has finished 👁️👄👁️ Your app is available here |
Hi @allemas, you can already check the editorial linter warnings related to this file to modify it. |
dde6dc1
to
6f64ca4
Compare
🚀 You updated your review app. Check it here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @allemas,
I added two suggestions and another sentence needs to be clearer.
@@ -66,9 +66,10 @@ Fields | |||
|
|||
* `api/production/sso_url` - The production endpoint for single sign-on. | |||
|
|||
* `api/test/base_url` - The test endpoint on which Clever Cloud sends actions requests. Used to test your service when you create an add-on provider. After the add-on creation,`api/production/base_url` is used. | |||
* `api/test/base_url` - The test endpoint on which Clever Cloud sends actions requests. Used to test your service when you create an add-on provider. After the add-on creation,`api/production/base_url` is used. If you're **not using** a test environment, set the same value as `api/production/base_url`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"After the add-on creation,api/production/base_url
is used" : by who or by what @allemas ?
* `api/test/base_url` - The test endpoint on which Clever Cloud sends actions requests. Used to test your service when you create an add-on provider. After the add-on creation,`api/production/base_url` is used. If you're **not using** a test environment, set the same value as `api/production/base_url`. | |
* `api/test/base_url` - The test endpoint on which Clever Cloud sends actions requests. Use it to test your service when you create an add-on provider. After the add-on creation,`api/production/base_url` is used. If you're **not using** a test environment, set the same value as `api/production/base_url`. |
|
||
* `api/test/sso_url` - The test endpoint for single sign-on. Used to test your service when you create an add-on provider. After that, the `api/production/sso_url` is used. | ||
* `api/test/sso_url` - The test endpoint for single sign-on. Used to test your service when you create an add-on provider. After that, the `api/production/sso_url` is used. If you're **not using** a test environment, set the same value as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the api/production/sso_url
is used": idem
* `api/test/sso_url` - The test endpoint for single sign-on. Used to test your service when you create an add-on provider. After that, the `api/production/sso_url` is used. If you're **not using** a test environment, set the same value as | |
* `api/test/sso_url` - The test endpoint for single sign-on. Use it to test your service when you create an add-on provider. After that, the `api/production/sso_url` is used. If you're **not using** a test environment, set the same value as |
🚀 You updated your review app. Check it here |
Describe your PR
In clever's internal functioning, if there is no test environment, the addon doesn't work properly.
I've added a note to this subject in the document, specifying that if there is no test environment, the same thing must be entered as for “prod”.