Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add param (tokenOwner) in checkSendLimit method #168

Open
llunaCreixent opened this issue Mar 20, 2023 · 1 comment
Open

Add param (tokenOwner) in checkSendLimit method #168

llunaCreixent opened this issue Mar 20, 2023 · 1 comment
Assignees
@juanenrisley

Comments

@llunaCreixent
Copy link
Member

The checkSendLimit method of the core checks the sent limit of the token of the 'from' address, which is contradictory with the policy of "returning tokens to their owners". This method is only used by myxo when calculating maxFlow. I suggest we refactor the method to include the tokenOwner as param too.
@llunaCreixent llunaCreixent mentioned this issue Mar 20, 2023
Merged
@juanenrisley juanenrisley mentioned this issue Aug 31, 2023
Merged
3 tasks
@juanenrisley
Copy link
Collaborator

juanenrisley commented Aug 31, 2023 •
edited
Loading

This issue is fixed with #226

Problem is that will be closed when merged as production build so until then, will be blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanenrisley juanenrisley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juanenrisley @llunaCreixent