Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Include ninja #129

Open
particleflux opened this issue Jan 17, 2024 · 8 comments
Open

Feature Request: Include ninja #129

particleflux opened this issue Jan 17, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@particleflux
Copy link

Describe the Feature Request
Include ninja build system in the cimg/android variants.

Is your feature request related to a particular problem?
There's some packages switching from cmake to ninja build system, and it's probably getting more projects using it in the future.

See: for example: software-mansion/react-native-reanimated#5498

How will this feature request benefit CircleCI jobs using this image?

  • job speedup for those with manually installed ninja
  • can run on linux docker images instead of the machine executor of Mac (see issue linked above)

Describe alternatives you have considered

@menttys
Copy link

menttys commented Feb 5, 2024

Any updates here? 🙏

@HaleyWardo
Copy link

HaleyWardo commented Feb 13, 2024

Any updates here? 🙏

Running into the same issue with RN and react-native-reanimated. Wondering if there are any updates as well.

@anhkieet
Copy link

Any updates here? I am facing the same issue

@jbarbe-hozana
Copy link

Facing the same issue here

@jpsierens88
Copy link

I am getting

[RUN_GRADLEW] Execution failed for task ':shopify_react-native-skia:configureCMakeRelWithDebInfo[arm64-v8a]'.
[RUN_GRADLEW] >
[RUN_GRADLEW] [CXX1416] Could not find Ninja on PATH or in SDK CMake bin folders.

using cimg/android:2024.01.1-browsers

@SuperBesse
Copy link

SuperBesse commented Jul 11, 2024

Hello, any news concerning this issue ?
On my side:

  • What went wrong:
    Execution failed for task ':react-native-reanimated:configureCMakeRelWithDebInfo[arm64-v8a]'.
    [CXX1416] Could not find Ninja on PATH or in SDK CMake bin folders.

@Asad-wego
Copy link

I encountered an error while updating my React Native project from version 0.72.x to 0.74.3. The project configuration includes:

React Native: 0.74.3
React Native Reanimated: ^3.14.0
Gradle: Updated from 7.5 to 8.7
Build Tool: Fastlane
CI Environment: CircleCI
Docker Image: cimg/android:2023.08.1-node
Problem
The project works fine on my local machine in development mode, and I can generate builds using Fastlane on my machine without any issues. However, when running the build job on CircleCI using
bundle exec fastlane staging I encounter the following error:

> Task :react-native-reanimated:configureCMakeRelWithDebInfo[arm64-v8a] FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-reanimated:configureCMakeRelWithDebInfo[arm64-v8a]'.
> [CXX1416] Could not find Ninja on PATH or in SDK CMake bin folders.

Has anyone encountered a similar issue or found a solution for this? Any steps or suggestions to fix this would be greatly appreciated.
Thank you!

@donaldCull
Copy link

I got this issue as well but slightly different error with Expo.

image: cimg/android:2024.08-node
react-native: "0.74.5",
expo: "~51.0.28",

[RUN_GRADLEW] FAILURE: Build failed with an exception. [RUN_GRADLEW] * What went wrong: [RUN_GRADLEW] Execution failed for task ':expo-modules-core:configureCMakeRelWithDebInfo[arm64-v8a]'. [RUN_GRADLEW] > [CXX1416] Could not find Ninja on PATH or in SDK CMake bin folders.

I managed to fix it by using the android machine image instead https://circleci.com/developer/machine/image/android. Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants