Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore additions #25

Open
shua123 opened this issue Apr 19, 2015 · 0 comments
Open

.gitignore additions #25

shua123 opened this issue Apr 19, 2015 · 0 comments

Comments

@shua123
Copy link
Contributor

shua123 commented Apr 19, 2015

Since the documentation recommends putting Kettle folders within the kit folder structure I would suggest adding data-integration*/ to .gitignore

Maybe also add DataSync/config.json so that password and connection settings are not accidently committed to a public repo. I'm not sure. There are also other settings that end up saved in generic files like the Email settings in open-data-etl-kit/ETL/Utilities/ETL_Completion_E-Mail.ktr. It might be helpful to pull all settings like that out and put into `kettle.properties' or some other environment variable type file.

In general, I'm just trying to make it clearer what files & folders can be safely in a public repo vs which ones probably shouldn't be (config settings, dataset specific files, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants