Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement of ionic charge #6

Open
tomyan112 opened this issue Mar 5, 2022 · 7 comments
Open

Placement of ionic charge #6

tomyan112 opened this issue Mar 5, 2022 · 7 comments
Assignees
Labels
By Design This is working as designed

Comments

@tomyan112
Copy link

Describe the bug
Currently the charge is place on the upper right of the atom rather than upper right of the polymeric ion
image

Describe the solution you'd like
image

Screenshots
From IUPAC Red book
image

Describe alternatives you've considered
Place charge on the upper right by default and allow other position.

@MikeWilliams-UK
Copy link
Contributor

Over to you on this one @deadlyvices, however the image @tomyan112 is quoting from does not cover the scenario where implicit H are shown.

@Chem4Word Chem4Word locked as resolved and limited conversation to collaborators Mar 5, 2022
@MikeWilliams-UK
Copy link
Contributor

@deadlyvices please confirm that you agree that this is by design.

@Wydna
Copy link

Wydna commented Mar 8, 2022

I agree with Tom. The change is correct.

@MikeWilliams-UK
Copy link
Contributor

@Wydna if you agree with @tomyan112, then the charge as drawn in Chem4word is wrong. (Not correct as you have said above)

@Wydna
Copy link

Wydna commented Mar 8, 2022

Read the comment again. The CHANGE is correct. If IUPAC places the charge where Tom has indicated, then Chem4Word is incorrect.

@deadlyvices
Copy link
Contributor

There's a couple of things mixed up here: placement of charge and handling of text representations of compounds. At the moment, a compound which is appears as if it is text is is simply drawn out by Chem4Word. Hence, the - in OH- appears above the charged atom, in this case an O, and then the H is drawn. This is because Chem4Word requires that the O is drawn out separately.

We will need to address this when we attack semantic entities in text representations. For this reason , I suggest we park this issue for now.

@deadlyvices
Copy link
Contributor

Hi @tomyan112 : would you like to help us beta-test the next version of Chem4Word? Please respond to this thread if you would like to help.

@Chem4Word Chem4Word unlocked this conversation Oct 8, 2024
@MikeWilliams-UK MikeWilliams-UK transferred this issue from Chem4Word/Version3-2 Oct 8, 2024
@MikeWilliams-UK MikeWilliams-UK added the By Design This is working as designed label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
By Design This is working as designed
Development

No branches or pull requests

4 participants