-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF1Plus: 403 when fetching index.mpd #1428
base: dev
Are you sure you want to change the base?
Conversation
Revert to Draft since the testing may not have covered the use-case (#1427 (comment)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un petit changement de style pour garder la lisibilité du code:
# use custom_license_headers only if it is set, else fallback to stream_headers
if custom_license_headers:
license_headers = urlencode(custom_license_headers)
else:
license_headers = stream_headers
license_url = '%s|%s|R{SSM}|' % (license_url, license_headers)
au lieu de
license_url = '%s|%s|R{SSM}|' % (license_url, urlencode(custom_license_headers) if custom_license_headers else stream_headers) # use custom_license_headers only if it is set, else fallback to stream_headers
Flake8 complains |
(i'm still waiting for a DRM-protected show on TF1 to confirm that it fixes the issue !) |
So I will wait for a few days before merging. |
8353682
to
9026e81
Compare
des nouvelles? |
Je regarde plusieurs fois par jour, et j'arrive toujours pas à en trouver, je vais me faire un petit robot pour surveiller quand est-ce qu'un flux protégé par Widevine passe sur tf1+. |
PR to fix #1427.
It has been tested successfully on LibreElec 12.0.1 with Kodi 21.1.0:
/!: IMHO: it could be useful to make the
get_stream_with_quality
method differenciate the headers given toinputstream.adaptive.stream_headers
(+inputstream.adaptive.manifest_headers
) and the headers given to the DRM license requests.Because such a change should impact almost all already implemented channels, I have added a parameter to the method which emulates to old behavior when it's None, and used as I want when filled.
I'm open to improvments, I'm not really happy with the parameter name nor the "workaround" behavior !