Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken flame examples in experimental MATLAB toolbox #1722

Open
ischoegl opened this issue Jun 22, 2024 · 5 comments
Open

Broken flame examples in experimental MATLAB toolbox #1722

ischoegl opened this issue Jun 22, 2024 · 5 comments

Comments

@ischoegl
Copy link
Member

ischoegl commented Jun 22, 2024

Problem description

flame1.m, flame2.m and diff_flame.m examples no longer work: the first fails to converge, and temperatures of the other two are equal to inlet temperatures.

Steps to reproduce

  1. Install Cantera from scratch
  2. Follow instructions in interfaces/matlab_experimental/readme.md
  3. Run one of the flame examples

Behavior

No combustion is observed

System information

  • Cantera version: latest main
  • OS: macOS
  • Python/MATLAB/other software versions: MATLAB R2023b

Other context

Issue was discovered when testing changes in #1619, but same behavior was observed on current main.

@speth
Copy link
Member

speth commented Jun 22, 2024

Using the experimental Matlab toolbox from main with libcantera from 3.0.0 (conda-forge package), I observe the same problems with all three examples.

Using the experimental Matlab toolbox from v3.0.0 with libcantera from 3.0.0 (conda-forge package), flame1.m and flame2.m exhibit the same problems. However, diff_flame.m successfully solves a non-extinct flame.

@ischoegl
Copy link
Member Author

Thanks for confirming, @speth. I’m surprised that this didn’t work as far back as when we released 3.0. Tagging @ssun30 and @rwest

@rwest
Copy link
Member

rwest commented Jun 22, 2024

We'll take a look this week. I think some MATLAB toolbox work is in our docket anyway. Thanks for tagging us.

@speth
Copy link
Member

speth commented Jun 22, 2024

git bisect tells me that the commit that broke diff_flame.m is this one: 3a9bc6a.

@ischoegl
Copy link
Member Author

ischoegl commented Jun 23, 2024

@rwest and @ssun30 ... please make sure to rebase after #1619 is merged, as that PR introduces some updates to nomenclature, which affect clib (it actually adopts MATLAB nomenclature for Flow1D within C++, as it makes more sense than the old StFlow)

PS: #1619 is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants