Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source as instance of dedicated class #32

Closed
dafyddstephenson opened this issue Aug 19, 2024 · 0 comments
Closed

source as instance of dedicated class #32

dafyddstephenson opened this issue Aug 19, 2024 · 0 comments
Assignees
Labels
internals non-user-facing changes

Comments

@dafyddstephenson
Copy link
Contributor

Currently source (or source_repo in some cases) is a str containing a URL (or soon, a local path). Meanwhile every class with a source-like attribute has a get() method. As we support more flexibility (e.g. local files, roms-tools integration), source should be an instance of a dedicated class, rather than str. This class should have logic for handling remote vs. local, different file types, repos, etc., and could likely also encapsulate a single get() method rather than this being defined separately for multiple different classes.

@dafyddstephenson dafyddstephenson added the internals non-user-facing changes label Aug 19, 2024
@dafyddstephenson dafyddstephenson self-assigned this Aug 19, 2024
@dafyddstephenson dafyddstephenson changed the title source class source as instance of dedicated class Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals non-user-facing changes
Projects
None yet
Development

No branches or pull requests

1 participant