You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently source (or source_repo in some cases) is a str containing a URL (or soon, a local path). Meanwhile every class with a source-like attribute has a get() method. As we support more flexibility (e.g. local files, roms-tools integration), source should be an instance of a dedicated class, rather than str. This class should have logic for handling remote vs. local, different file types, repos, etc., and could likely also encapsulate a single get() method rather than this being defined separately for multiple different classes.
The text was updated successfully, but these errors were encountered:
Currently
source
(orsource_repo
in some cases) is astr
containing a URL (or soon, a local path). Meanwhile every class with asource
-like attribute has aget()
method. As we support more flexibility (e.g. local files, roms-tools integration),source
should be an instance of a dedicated class, rather thanstr
. This class should have logic for handling remote vs. local, different file types, repos, etc., and could likely also encapsulate a singleget()
method rather than this being defined separately for multiple different classes.The text was updated successfully, but these errors were encountered: