Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Hypergeometric Distribution CDF update will change input #132

Open
Freymaurer opened this issue Jun 23, 2022 · 0 comments
Open

[BUG] Hypergeometric Distribution CDF update will change input #132

Freymaurer opened this issue Jun 23, 2022 · 0 comments
Labels
bug

Comments

@Freymaurer
Copy link
Member

Describe the bug
Found that FSharp.Stats.Distributions.hypergeometric(..).CDF is float -> float, whereas the input k (the number of drawn success events) should be int, therefore int -> float.

Found here:

BioFSharp/src/BioFSharp.Stats/OntologyEnrichment.fs

Line 88 in 08618f7

1. - hp.CDF (float (numberOfDEsInBin - 1))

Will be changed in FSharp.Stats somewhere in the future.
@Freymaurer Freymaurer added the bug label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Freymaurer