Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the threshold is set to 1 in the configuration, the initial event sent for client 2 is always multicast rather than unicast. #763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Vignesh-Murugappan
Copy link

When the threshold is set to 1 in the configuration, the initial event sent for client 2 is always multicast rather than unicast.

the initial event sent for client 2 is always multicast
rather than unicast.

Signed-off-by: Vignesh MURUGAPPAN <vignesh.murugappan@valeo.com>
@duartenfonseca
Copy link
Collaborator

Hi, this fails when building:

Screenshot from 2024-09-10 11-53-06

@Vignesh-Murugappan
Copy link
Author

Hi, this fails when building:

Screenshot from 2024-09-10 11-53-06

Resolved. Thanks for your comment.

@duartenfonseca
Copy link
Collaborator

@Vignesh-Murugappan if you read here: https://github.com/COVESA/vsomeip/blob/637fb6ccce969f89621660dd481badb29a90d661/documentation/vsomeipUserGuide#L662C1-L669C53
it says:

Specifies when to use multicast and when to use unicast to send a notification event.
Must be set to a non-negative number. If it is set to zero, all events of the eventgroup
will be sent by unicast. Otherwise, the events will be sent by unicast as long as the
number of subscribers is lower than the threshold and by multicast if the number
of subscribers is greater or equal. This means, a threshold of 1 will lead to all events
being sent by multicast
. The default value is 0.
which seems to go against what you describe as your fix

@Vignesh-Murugappan
Copy link
Author

Vignesh-Murugappan commented Sep 11, 2024

@Vignesh-Murugappan if you read here: https://github.com/COVESA/vsomeip/blob/637fb6ccce969f89621660dd481badb29a90d661/documentation/vsomeipUserGuide#L662C1-L669C53 it says:

Specifies when to use multicast and when to use unicast to send a notification event.
Must be set to a non-negative number. If it is set to zero, all events of the eventgroup
will be sent by unicast. Otherwise, the events will be sent by unicast as long as the
number of subscribers is lower than the threshold and by multicast if the number
of subscribers is greater or equal. This means, a threshold of 1 will lead to all events
being sent by multicast
. The default value is 0.
which seems to go against what you describe as your fix

**Yes, you're correct. When the threshold is set to 1, the expectation is that all events should be multicast.

However, no initial event is sent. According to PRS_SOMEIPSD_00487, an initial event should be sent to subscribers immediately after subscription acknowledgment for all new subscriptions. If a subscription is already active and is subsequently updated by a Subscribe Eventgroup entry, no initial events should be dispatched.

In my case, when the threshold is set to 1, the initial event is received by the first subscriber but not by the second.

In summary, when the threshold is 'N', initial events are sent to all 'N' subscribers, but not to the 'N+1'-th subscriber and so on.

With the proposed change, the behavior aligns with expectations, and there are no issues observed with multicast or unicast behavior regardless of whether the threshold is set or not.**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants