Log offers on first occurrence in routing manager #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For debugging purposes, the routing manager has been updated to log the first time a new service is detected to be offered.
goncaloalmeida
suggested changes
Jul 30, 2024
| @@ -1084,6 +1084,13 @@ routing_manager_stub::on_net_state_change( | |||
|
|
|||
| void routing_manager_stub::on_offer_service(client_t _client, | |||
| service_t _service, instance_t _instance, major_version_t _major, minor_version_t _minor) { | |||
|
|
|||
| VSOMEIP_DEBUG << "ON_OFFER_SERVICE(" | |||
There was a problem hiding this comment.
Please use func name, for example:
VSOMEIP_DEBUG << __ func __ << ": ..
There was a problem hiding this comment.
@falk-haleytek if you could make this change also, i would merge this too
There was a problem hiding this comment.
Done! 4211311
goncaloalmeida
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging purposes, the routing manager has been updated to log the first time a new service is detected to be offered.