feat: Allowing to use zcollection without any dask cluster. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of these changes is to enable the use of a zcollection without requiring a Dask cluster.
This functionality is made possible by the new
distributedparameter, which has been added to all functions and methods that rely on Dask (except for the map and map_overlap functions, as they are specifically designed for Dask usage).However, the choice of the distributed keyword might not be ideal, given that we are working in a context where the distributed package is heavily used, which could lead to some confusion.
The keyword was already in use within a sub-function, so I adopted it, but this is open for discussion.
@robin-cls: Could you review this and confirm whether it meets your needs?
@fbriol : Could you evaluate the implementation and either approve it or suggest an alternative approach?