Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review semantics and structure of some objects and methods #16

Open
alelom opened this issue Feb 19, 2021 · 0 comments
Open

Review semantics and structure of some objects and methods #16

alelom opened this issue Feb 19, 2021 · 0 comments
Labels
type:feature New capability or enhancement

Comments

@alelom
Copy link
Contributor

alelom commented Feb 19, 2021

Suggestions:

  • Conflate ZoneSpecification and SpatialSpecification in one only object: ZoneSpecification.
    The ZoneSpecification can have, among its properties, a List<IGeometry> locations where it should be applied to - but it can be created without.
  • Add a method ApplyZoneSpecification that takes a List<IBHoMObject> locations (objects that keep track of geometrical locations and their Zone, like ZoneReferenceLine) and List<ZoneSpecification> zoneSpecifications and populates the locations of the ZoneSpec.
  • Change the current method named ApplySpecifications(List<object> object, List<ISpecification> specifications) to Verify(List<object> object, List<ISpecification>specification) (or Validate? @al-fisher )
@alelom alelom added the type:feature New capability or enhancement label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant