Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the version and loader information output in I18nUpdateMod.log #30

Open
3gf8jv4dv opened this issue Nov 4, 2024 · 0 comments
Open

Comments

@3gf8jv4dv
Copy link

public static void init(Path minecraftPath, String minecraftVersion, String loader) {
try (InputStream is = I18nUpdateMod.class.getResourceAsStream("/i18nMetaData.json")) {
MOD_VERSION = GSON.fromJson(new InputStreamReader(is), JsonObject.class).get("version").getAsString();
} catch (Exception e) {
Log.warning("Error getting version: " + e);
}
Log.info(String.format("I18nUpdate Mod %s is loaded in %s with %s", MOD_VERSION, minecraftVersion, loader));

I tried to find the relevant code. The current logic is that even if the user uses NeoForge/Quilt, it will be output as Forge/Fabric in the log.

Could you please consider changing the relevant logic to determine the loader actually used by the client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant