You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Building this project on my machine yielded several errors that I had to manually fix.
Changes that were necessary on my machine to get this to compile:
An import in build.mjs:
--- a/util/build.mjs+++ b/util/build.mjs@@ -6,7 +6,8 @@ import { Version, UpdateVersion, ResetVersion } from './versioning.mjs';
import { Logger } from './log.mjs';
import { exit } from 'process';
-import { name as PluginName } from "../plugin.json" with { type: "json" };+import name from "../plugin.json" with { type: "json" };+const PluginName = name;
import deploy from "../deploy.json" with { type: "json" };
if (process.argv.includes('-h') || process.argv.includes('--help')) {
~
In lipe (this is an upstream issue but I believe it's a library by the author of this project), lib/ES6/utils/util.js,
-import { Format } from "./Formatter";+import { Format } from "./Formatter.js";
In backend/Cargo.toml, adding time = "0.3.36" as a dependency (otherwise it would pull 0.2.22 as a dependency of actix, which refuses to build in current rustc versions.
These were all surprising issues. It's rare to see rustc not being backwards compatible, but apparently in this case the only fix is updating time manually. (1) I think is problematic because json imports are experimental in node (https://nodejs.org/api/esm.html#json-modules) and so there might be a syntax difference with older node versions. I have no idea what could cause (2) to work on one machine but not mine (file extensions have been mandatory in ESM import modules since at least v20, see https://nodejs.org/docs/latest-v20.x/api/esm.html#mandatory-file-extensions)
The above was necessary in order to get ./build.sh to work with the following software versions:
rustc 1.80.1 (3f5fd8dd4 2024-08-06) (Arch Linux rust 1:1.80.1-1)
Further, adding a couple lines in the README for build instructions would be nice - in particular that node, pnpm and cargo are needed, and if newer versions are explicitly unsupported (which really shouldn't be the case), what version this is supposed to run on.
The text was updated successfully, but these errors were encountered:
The lipe problem is known and 110% my fault (have been too lazy to update. Will get on that). The rest is very surprising to me. All versions are defined in the mise.toml in the project root. Mise can be used to automatically manage the installed versions. It was passing in Github which is a little strange. I fixed the Json thing and that is now in master. I'll do the same for lipe and as for cargo I reccomend downgrading and using 1.79 for the moment.
I am working on a contributing section to outline the code of conduct and how to get started developing.
Building this project on my machine yielded several errors that I had to manually fix.
Changes that were necessary on my machine to get this to compile:
build.mjs
:lipe
(this is an upstream issue but I believe it's a library by the author of this project),lib/ES6/utils/util.js
,backend/Cargo.toml
, addingtime = "0.3.36"
as a dependency (otherwise it would pull0.2.22
as a dependency ofactix
, which refuses to build in currentrustc
versions.These were all surprising issues. It's rare to see
rustc
not being backwards compatible, but apparently in this case the only fix is updatingtime
manually. (1) I think is problematic because json imports are experimental in node (https://nodejs.org/api/esm.html#json-modules) and so there might be a syntax difference with older node versions. I have no idea what could cause (2) to work on one machine but not mine (file extensions have been mandatory in ESM import modules since at least v20, see https://nodejs.org/docs/latest-v20.x/api/esm.html#mandatory-file-extensions)The above was necessary in order to get
./build.sh
to work with the following software versions:rustc 1.80.1 (3f5fd8dd4 2024-08-06) (Arch Linux rust 1:1.80.1-1)
cargo 1.80.1 (376290515 2024-07-16)
node --version
isv22.7.0
pnpm --version
is9.7.1
This is on master branch, 862055a.
Further, adding a couple lines in the README for build instructions would be nice - in particular that
node
,pnpm
andcargo
are needed, and if newer versions are explicitly unsupported (which really shouldn't be the case), what version this is supposed to run on.The text was updated successfully, but these errors were encountered: