New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename attribute pulse of Pulse to waveform for clarity. #16

Open

romanwixinger opened this issue Mar 31, 2023 · 0 comments

Assignees

Labels

Collaborator

romanwixinger commented Mar 31, 2023

Problem:

At the moment, instances of Pulse are named pulse, but they also have the attribute pulse which is a callable.
This is ambiguous.

Solution:

Rename the attribute "pulse" to "waveform".
Then a Pulse instance called pulse has attributes "waveform" and "parametrization".

romanwixinger added the enhancement label

romanwixinger self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment