Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Flask-Script is Deprecated #984

Open
xuhang57 opened this issue Mar 22, 2018 · 2 comments
Open

Flask-Script is Deprecated #984

xuhang57 opened this issue Mar 22, 2018 · 2 comments

Comments

@xuhang57
Copy link
Contributor

xuhang57 commented Mar 22, 2018

https://github.com/smurfix/flask-script
And as mentioned here: #975
we need to figure out how to deal with Flask-Migrate

screen shot 2018-03-22 at 12 54 14

@xuhang57
Copy link
Contributor Author

xuhang57 commented Mar 22, 2018

I believe you can use the flask CLI with Flask-Migrate as well:
https://flask-migrate.readthedocs.io/en/latest/

Not sure how to handle this yet.
Maybe rather than:

hil-admin db create which is essentially: cread_db() in hil.migrations
Should we do flask db init?

So, the question is, should we keep using flask-script so we can build a cli such as hil-admin or we should use flask cli instead.

@zenhack
Copy link
Contributor

zenhack commented Mar 22, 2018

The flask command is just a wrapper on top of click. It would be nice to integrate hil-admin with that since we're using click for the hil command anyway.

It might be nice to keep a thin wrapper around it, just to set up a few things automatically and be a bit more intuitive to sysadmins who are not also python developers; I don't like to expose too much internal tooling goop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants