Remove obsolete shortcuts and shortcuts only used in GNOME #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustSoup312
force-pushed
the
obsolete-shortcuts
branch
from
c5aa776
to
d3f4a4f
Compare
serebit
changed the title
2 tasks
JustSoup312
force-pushed
the
obsolete-shortcuts
branch
from
d3f4a4f
to
dfe6251
Compare
JustSoup312
force-pushed
the
obsolete-shortcuts
branch
from
dfe6251
to
18077c8
Compare
fossfreedom
reviewed
May 8, 2024
| @@ -13,7 +9,5 @@ | |||
|
|
|||
| <KeyListEntry name="home" description="Home folder"/> | |||
|
|
|||
| <KeyListEntry name="search" description="Search" msgctxt="keybinding">Search</KeyListEntry> | |||
|
|
|||
| @@ -1,10 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <KeyListEntries group="system" schema="org.gnome.settings-daemon.plugins.media-keys" name="Launchers"> | |||
|
|
|||
| <KeyListEntry name="help" description="Launch help browser"/> | |||
|
|
|||
| <KeyListEntry name="control-center" description="Settings"/> | |||
There was a problem hiding this comment.
Kind of innocuous ... I suppose if set this should in theory launch budgie-control-center but I don't think we have a helper to-do this. So fair enough
| @@ -1,10 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <KeyListEntries group="system" schema="org.gnome.settings-daemon.plugins.media-keys" name="Launchers"> | |||
|
|
|||
| <KeyListEntry name="help" description="Launch help browser"/> | |||
| @@ -1,20 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <KeyListEntries group="system" name="Accessibility" schema="org.gnome.settings-daemon.plugins.media-keys"> | |||
|
|
|||
| <KeyListEntry name="magnifier" description="Turn zoom on or off"/> | |||
There was a problem hiding this comment.
Some distros (e.g.) Ubuntu Budgie ship third-party tools such as magnus for the zoom feature. I'll need to check this together with the Zoom in/out
| <KeyListEntry name="screenreader" description="Turn screen reader on or off"/> | ||
|
|
||
| <KeyListEntry name="on-screen-keyboard" description="Turn on-screen keyboard on or off"/> |
There was a problem hiding this comment.
Definitely not - onboard if shipped should be launched.
| <KeyListEntry name="increase-text-size" description="Increase text size"/> | ||
|
|
||
| <KeyListEntry name="decrease-text-size" description="Decrease text size"/> | ||
|
|
||
| <KeyListEntry name="toggle-contrast" description="High contrast on or off"/> |
There was a problem hiding this comment.
Will need to check this - again its an accessory feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #46
Depends: BuddiesOfBudgie/magpie#21
Many keyboard shortcuts in
budgie-control-centerdo not work in Budgie. This MR removes these shortcuts for now.Submitter Checklist
git rebase -i(if needed)