Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SirenMatchers doesn't check ISirenEntity.Properties #13

Open
ryantmer opened this issue Aug 15, 2017 · 0 comments
Open

SirenMatchers doesn't check ISirenEntity.Properties #13

ryantmer opened this issue Aug 15, 2017 · 0 comments

Comments

@ryantmer
Copy link
Collaborator

ryantmer commented Aug 15, 2017

See here.

Wasn't able to determine a good way to define matching/equality with the properties as dynamic in #11. One possible solution would be to introduce a breaking change so that ISirenEntity.Properties is an ISirenProperties object, e.g.

interface ISirenProperties {
    Equals(ISirenProperties other);
    Matches(ISirenProperties other);
}

Upon implementation, you would define your class MySirenProperties : ISirenProperties, implement the interface, and add your arbitrary properties. This leaves it up to the implementer to decide what "equality" and "matching" is w.r.t. their properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant