Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Detection #11

Open
1 task
Bluejee opened this issue Aug 31, 2023 · 0 comments
Open
1 task

Refine Detection #11

Bluejee opened this issue Aug 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Bluejee
Copy link
Owner

Bluejee commented Aug 31, 2023

Please view the Contributing Guidelines for information on Contributing.

Is your feature request related to a problem? Please describe.
The current comparison algorithm is kind of a database search algorithm that looks through the database and selects all the lines which lie in the error region. It does not take into account the shift in the spectrum which might cause a lot of false positive peaks.
This also causes lots of detected peaks to match with multiple elements. Obviously the current search is important as it gives us lots of good results, but we need a way to refine the results.

Describe the solution you'd like

  • Add a function which takes in the dictionary output of the element_list_comparison() function and refines the results and removes false positives. This can be done either using a statistical analysis of the result or it can be done using a standard reference of trusted peaks or combination of peaks.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Bluejee Bluejee added the enhancement New feature or request label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant