Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon showing up as 1.0.0 instead of 10.0.0 #140

Closed
whatisboom opened this issue Oct 26, 2022 · 4 comments
Closed

Addon showing up as 1.0.0 instead of 10.0.0 #140

whatisboom opened this issue Oct 26, 2022 · 4 comments

Comments

@whatisboom
Copy link

whatisboom commented Oct 26, 2022

I just updated my addon that uses this script and updated the toc Interface value to 100000 and it was uploaded to curseforge as game version 1.0.0. I assume the script is looking at either the first 3 or 6 numbers in that string to determine the game version, but I am not a bash developer and have had not luck finding where that would be the case in your script.

@nebularg
Copy link
Member

I assume you're using v1 or an outdated fork, switch to v2/this repo to use the latest version

@funkydude
Copy link
Member

funkydude commented Oct 26, 2022

Your addon is using the old version of the packager, v1.
You can see that here: https://github.com/whatisboom/EnchantCheck/blob/master/.github/workflows/release.yml#L39

Change it to v2 (for stable) or to master (for bleeding edge) and your issue will be resolved.

Here is a guide:
https://wowpedia.fandom.com/wiki/Using_the_BigWigs_Packager_with_GitHub_Actions#GitHub_workflow

@funkydude funkydude pinned this issue Oct 26, 2022
@funkydude funkydude changed the title Support for 10.0.0+ toc interface value Addon showing up as 1.0.0 instead of 10.0.0 Oct 26, 2022
@funkydude
Copy link
Member

Pinning this for a while

@whatisboom
Copy link
Author

awesome, feel free to close this whenever, if you want to leave it open while its pinned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants