Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong tier order in GUI #51

Open
QuestionCatcher opened this issue Nov 2, 2023 · 3 comments
Open

wrong tier order in GUI #51

QuestionCatcher opened this issue Nov 2, 2023 · 3 comments
Assignees
Labels
Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug Something isn't right

Comments

@QuestionCatcher
Copy link

QuestionCatcher commented Nov 2, 2023

Expected behavior

in config file i have tier order:
Tier1
Tier2
Tier3
Tier4

For every single upgrade i have on server

Observed/Actual behavior

under /is upgrade command in GUI some items starts their upgrade from Tier3 or Tier4

Steps/models to reproduce

  1. Add upgrades and tiers
  2. Restart sever
  3. Run /is upgrade

BentoBox version

[16:28:20] [Server thread/INFO]: Running PAPER 1.20.1.
[16:28:20] [Server thread/INFO]: BentoBox version: 1.24.1
[16:28:20] [Server thread/INFO]: Database: JSON
[16:28:20] [Server thread/INFO]: Loaded Game Worlds:
[16:28:20] [Server thread/INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[16:28:20] [Server thread/INFO]: Loaded Addons:
[16:28:20] [Server thread/INFO]: Bank 1.7.0 (ENABLED)
[16:28:20] [Server thread/INFO]: Biomes 2.1.1 (ENABLED)
[16:28:20] [Server thread/INFO]: Border 4.1.1 (ENABLED)
[16:28:20] [Server thread/INFO]: BSkyBlock 1.16.1 (ENABLED)
[16:28:20] [Server thread/INFO]: Chat 1.1.4 (ENABLED)
[16:28:20] [Server thread/INFO]: ControlPanel 1.13.0 (ENABLED)
[16:28:20] [Server thread/INFO]: ExtraMobs 1.12 (ENABLED)
[16:28:20] [Server thread/INFO]: IslandFly 1.11.0 (ENABLED)
[16:28:20] [Server thread/INFO]: Level 2.11.0 (ENABLED)
[16:28:20] [Server thread/INFO]: Likes 2.3.1 (ENABLED)
[16:28:20] [Server thread/INFO]: Limits 1.19.1 (ENABLED)
[16:28:20] [Server thread/INFO]: MagicCobblestoneGenerator 2.5.1 (ENABLED)
[16:28:20] [Server thread/INFO]: Upgrades 0.3.0-SNAPSHOT-b130 (ENABLED)
[16:28:20] [Server thread/INFO]: Visit 1.6.0 (ENABLED)
[16:28:20] [Server thread/INFO]: Warps 1.13.0 (ENABLED)

Plugin list

[16:28:36] [Server thread/INFO]: Server Plugins (53):
[16:28:36] [Server thread/INFO]: Paper Plugins:
[16:28:36] [Server thread/INFO]: - MarriageMaster, Minepacks
[16:28:36] [Server thread/INFO]: Bukkit Plugins:
[16:28:36] [Server thread/INFO]: - BanAnnouncer, BentoBox, BentoBox-Bank, BentoBox-Biomes, BentoBox-BSkyBlock, BentoBox-IslandFly, BentoBox-Level, BentoBox-Likes, BentoBox-Limits, BentoBox-MagicCobblestoneGenerator
[16:28:36] [Server thread/INFO]: BentoBox-Visit, BentoBox-Warps, Citizens, CMI, CMILib, CoreProtect, DailyRewardsPlus, DeluxeMenus, EasyCommandBlocker, ExcellentCrates
[16:28:36] [Server thread/INFO]: ezAuctions, EzChestShop, FastAsyncWorldEdit, FlareTokens, HeadDatabase, InventoryRollbackPlus, ItemEdit, Jobs, LiteBans, LotterySix
[16:28:36] [Server thread/INFO]: LPX, LuckPerms, NexEngine, PlaceholderAPI, ProtocolLib, Quests, ServerBackup, ShopGUIPlus, SpawnerMeta, Spicord
[16:28:36] [Server thread/INFO]: *T-Vouchers, TAB, Vault, ViaVersion, VoidSpawn, VotifierPlus, VotingPlugin, Vulcan, WorldGuard, WorldGuardExtraFlags
[16:28:36] [Server thread/INFO]: zAuctionHouseV3

Other

Tiers on fresh created island
Wrong order:
wrong_order
Config for Creeper upgrade with wrong tier order:

  CREEPER:
   tier1:
     max-level: 5
     upgrade: "3"
     island-min-level: "250"
     vault-cost: "10000"
   tier2:
     max-level: 5
     upgrade: "5"
     island-min-level: "1000"
     vault-cost: "[level]*2000"
   tier3:
     max-level: 5
     upgrade: "7"
     island-min-level: "2500"
     vault-cost: "[level]*2500"
   tier4:
     max-level: 5
     upgrade: "10"
     island-min-level: "5000"
     vault-cost: "[level]*10000"

Correct order:
corretc_order

Config for Cactus upgrade with correct tier order:

  CACTUS:
   tier1:
     max-level: 3
     upgrade: "5"
     island-min-level: "250"
     vault-cost: "10000"
   tier2:
     max-level: 5
     upgrade: "5"
     island-min-level: "1000"
     vault-cost: "[level]*2000"
   tier3:
     max-level: 6
     upgrade: "7"
     island-min-level: "2500"
     vault-cost: "[level]*2500"
   tier4:
     max-level: 4
     upgrade: "10"
     island-min-level: "5000"
     vault-cost: "[level]*7500"
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug Something isn't right labels Nov 12, 2023
@tastybento tastybento self-assigned this Nov 13, 2023
@tastybento
Copy link
Member

I'm trying to track this down. It's not my code, so it's a bit difficult. I think it's something to do with the sorting being lost somewhere, but it's complex. Please stand by.

@Meiyueh
Copy link

Meiyueh commented Feb 10, 2024

is it repaired?

@tastybento
Copy link
Member

No, sorry. I'll have another look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug Something isn't right
Projects
None yet
Development

No branches or pull requests

3 participants