Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostics: compute variables when necessary only #41

Open
BenMql opened this issue Oct 30, 2024 · 0 comments
Open

diagnostics: compute variables when necessary only #41

BenMql opened this issue Oct 30, 2024 · 0 comments

Comments

@BenMql
Copy link
Owner

BenMql commented Oct 30, 2024

In the pseudo-spectral approach, quadratic terms are computed in physical space, each of which requires 2 DFT (forward and backward). On the other hand, the current version of Coral can only export quantities that are computed in physical space. The rationale behind this was that, initially, typical diagnostics (e.g. the kinetic energy) would need to be computed anyway to march the equations in time.
However, detailed statistical analysis of the solution sometimes necessitates the computation of diagnostic quantities that do not directly enter the equations. Since the complexity of the code is proportional to the number of DFTs (at leading order), frequently computing additional quantities is wasteful

It would speed up the code if we could distinguish between dynamic and diagnostic variables.

Corollary: diagnostic variables should not be output at each timestep (this would negate the purpose of the distinction). In case a timeseries is demanded by the user in coral.timeseries, the output frequency should be, say 5:1 or 10:1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant