Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle invalid state for field number #521

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

yoannfleurydev
Copy link
Member

@yoannfleurydev yoannfleurydev commented Sep 5, 2024

Describe your changes

Add fieldState.error to make the input invalid when there are errors.

Screenshots

Before

image

After

image

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 0:12am

Copy link

sonarcloud bot commented Sep 5, 2024

@ivan-dalmet ivan-dalmet merged commit 0de897f into master Sep 5, 2024
7 checks passed
@ivan-dalmet ivan-dalmet deleted the fix/field-number-invalid-state branch September 5, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants