Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : Add unit tests on FormFields if isDisabled #515

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Feat : Add unit tests on FormFields if isDisabled #515

merged 2 commits into from
Aug 2, 2024

Conversation

Nikola-BS
Copy link
Contributor

@Nikola-BS Nikola-BS commented Jul 30, 2024 •
edited
Loading

Describe your changes

closes #507

  • Do the rest of the unit tests
  • Fixed a bug in FieldPassword

Screenshots

Documentation

Checklist

  • I performed a self review of my code
  • I ensured that everything is written in English
  • I tested the feature or fix on my local environment
  • I ran the pnpm storybook command and everything is working
  • If applicable, I updated the translations for english and french files
    (If you cannot update the french language, just let us know in the PR description)
  • If applicable, I updated the README.md
  • If applicable, I created a PR or an issue on the documentation repository
  • If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
start-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 8:19am

@Nikola-BS Nikola-BS self-assigned this Jul 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
52.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Nikola-BS Nikola-BS changed the title WIP : Add unit tests on FormFields if isDisabled Feat : Add unit tests on FormFields if isDisabled Jul 31, 2024
@yoannfleurydev yoannfleurydev merged commit dea33dc into master Aug 2, 2024
6 of 7 checks passed
@yoannfleurydev yoannfleurydev deleted the feat/unit-test branch August 2, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deelanM deelanM deelanM approved these changes

@yoannfleurydev yoannfleurydev yoannfleurydev approved these changes

Assignees

@Nikola-BS Nikola-BS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests on FormFields to check if isDisabled works just fine
3 participants
@Nikola-BS @yoannfleurydev @deelanM