fix: PR feedbacks

BearStudio · Oct 21, 2024 · 7cbdbfe · 7cbdbfe
1 parent c9ba9fc
commit 7cbdbfe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/features/auth/OAuthLogin.tsx b/src/features/auth/OAuthLogin.tsx
@@ -54,7 +54,7 @@ export const OAuthLoginButton = ({
 };
 
 export const OAuthLoginButtonsGrid = () => {
-  if (!OAUTH_PROVIDERS_ENABLED_ARRAY.some((p) => p.isEnabled)) return null;
+  if (!OAUTH_PROVIDERS_ENABLED_ARRAY.length) return null;
   return (
     <SimpleGrid columns={2} gap={3}>
       {OAUTH_PROVIDERS_ENABLED_ARRAY.map(({ provider }) => {

diff --git a/src/server/config/oauth/providers/google.ts b/src/server/config/oauth/providers/google.ts
@@ -48,7 +48,12 @@ export const google: OAuthClient = {
         message: 'Missing Google environment variables',
       });
     }
-    if (!codeVerifier) throw new Error('Missing codeVerifier');
+    if (!codeVerifier) {
+      throw new TRPCError({
+        code: 'BAD_REQUEST',
+        message: 'Missing codeVerifier',
+      });
+    }
     return googleClient.validateAuthorizationCode(code, codeVerifier);
   },
   getUser: async ({ accessToken, ctx }) => {