Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embedded normalize #23

Open
nwmcsween opened this issue Jul 16, 2018 · 5 comments
Open

Remove embedded normalize #23

nwmcsween opened this issue Jul 16, 2018 · 5 comments

Comments

@nwmcsween
Copy link

Instead of embedding normalize gutenberg should probably say it's required in the documentation then users could use a newer version of normalize

@BafS
Copy link
Owner

BafS commented Jul 19, 2018

Yes it could do it as a peer dependency, feel free to submit a patch.

@ghost
Copy link

ghost commented Feb 19, 2020

It appears the link in the gutenberg.scss is wrong. Instead of:

@import '../node_modules/normalize.css/normalize';

it should be:

@import '../../normalize.css/normalize';

@BafS
Copy link
Owner

BafS commented Feb 19, 2020

@fanchyfanch the path is correct, you can try to compile it with npx gulp. Do you include this file from another project ?

What we could do is use the tilda ~ (@import '~normalize.css/normalize') like webpack but it's not natively handled with gulp-sass.

@ghost
Copy link

ghost commented Feb 20, 2020

Actually, I'm loading gutenberg as a dependency in my project from SASS:

@import '~gutenberg-css/scss/gutenberg';

And when I compile my project with Webpack Encore, it throws an error "unable to find normalize.css".

I had to make an intermediary file to work as the "gutenberg.scss" entrypoint and to load every sub-files, including normalize.css like:

@import '~normalize.css/normalize';

@BafS
Copy link
Owner

BafS commented Mar 2, 2020

@fanchyfanch A new version was published (v0.6.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants