Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

432 fix division scrolling #434

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Conversation

hoerstl
Copy link

@hoerstl hoerstl commented Oct 21, 2024

Issue

In development, the sidebar for the courses page has a few formatting issues and its behavior is centered around the structure of the data rather than the use case. This pull request addresses both the structural flaws and the use case problems.

### Structural Issues
Notice that the sidebar's scrollbar doesn't extend all the way to the bottom of the page. This led to some confusing navigation where you could be at the bottom of the page but not see the bottom of the sidebar. What we did:

image

### Use Case Issues
The user does not care about what division their course abbreviation is in and these menus just make it harder to find the course they're searching for


Old state of the sidebar: image

Solution

Structural Issues

We restructured the base page so that the sidebar div actually fills up the whole height of the screen.

image

Use Case Issues

We created a select picker which lets you click the header and then simply search for the course abbreviation you want to look at. This field is searchable by the course abbreviation, division name, and division number.

image

To Test

  1. Checkout our branch. git checkout 432-Fix-Division-Scrolling
  2. Pull our branch. git pull origin 432-Fix-Division-Scrolling
  3. Navigate to the courses page using the navbar.
    image
  4. Select any term when prompted.
  5. Ensure that we can search for any course abbreviation on the sidebar and make sure the formatting looks good and feels intuitive.

Resolves Issue #432

@hoerstl
Copy link
Author

hoerstl commented Oct 21, 2024

@Karina-Agliullova
Copy link

If there is a way to fix it, then the problem is that when expanding the Problems, it jumps from up to down back and forth when I use scrolling, which is a little annoying
Screenshot (32)
Screenshot (33)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dual Scrolling between the sidebar and body makes the menu go invisible.
2 participants