Add e2e tests #458
Open
Add e2e tests #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration test for the entire pipeline
mkeesey
reviewed
Nov 26, 2024
| testcontainers.CleanupContainer(t, collectorContainer) | ||
| require.NoError(t, err) | ||
|
|
||
| t.Run("Logs", func(t *testing.T) { |
There was a problem hiding this comment.
Can we set the Logs and Metrics blocks to run with t.Parallel() so they can wait in parallel?
| buffer bytes.Buffer | ||
| } | ||
|
|
||
| func (b *threadsafeBuffer) Write(p []byte) (n int, err error) { |
There was a problem hiding this comment.
Do we need a wrapper to read the buffer? I think we probably need to have something that wraps reads with a lock operation too.
| } | ||
| }) | ||
|
|
||
| ingestorContainer, err := ingestor.Run(ctx, ingestor.WithCluster(ctx, k3sContainer)) |
There was a problem hiding this comment.
For a follow on PR, I think it would be nice to have a way to configure the Kusto batch policies so we can set them to something like 30s for logs (instead of the 5m we hard code them to) which hopefully speeds this test up a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test for the entire pipeline