Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add shortened customer bank statement" #3991

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Conversation

cesarcosta99
Copy link
Contributor

@cesarcosta99 cesarcosta99 commented Mar 18, 2022

Changes proposed in this Pull Request

We've stumbled upon questions on #3643 that may require changes on how we save the short statement descriptor in the settings. In order to avoid messing up with the settings structure, and generate compatibility issues, this PR is reverting the changes that added the shortened statement descriptor field.

Testing instructions

In case you'd like to double-check:

  1. Go to the WCPay settings.
  2. There is no Shortened customer bank statement field below the Full bank statement.
  3. Open the dev tools and reload the page.
  4. In the GET /wp-json/wc/v3/payments/settings request, there is no is_short_statement_descriptor_enabled and short_statement_descriptor in the response.
  5. Save the settings.
  6. In the POST /wp-json/wc/v3/payments/settings request, there is no is_short_statement_descriptor_enabled and short_statement_descriptor in the payload.

  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

  • Link to testing instructions from release testing doc : Add link here / 'QA Testing Not Applicable'

@cesarcosta99 cesarcosta99 self-assigned this Mar 18, 2022
@cesarcosta99 cesarcosta99 changed the title Partially revert "[Settings] Add shortened customer bank statement (#3625)" Revert "Add shortened customer bank statement" Mar 18, 2022
Copy link
Contributor

@reykjalin reykjalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@cesarcosta99 cesarcosta99 merged commit d0a8eba into develop Mar 19, 2022
@cesarcosta99 cesarcosta99 deleted the revert/3625 branch March 19, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: settings Issues related to Settings pr: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants