Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean statement descriptor value before saving it #3982

Open
cesarcosta99 opened this issue Mar 18, 2022 · 0 comments
Open

Clean statement descriptor value before saving it #3982

cesarcosta99 opened this issue Mar 18, 2022 · 0 comments
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. component: settings Issues related to Settings focus: account lifecycle type: enhancement The issue is a request for an enhancement.

Comments

@cesarcosta99
Copy link
Contributor

Description

This is a follow-up issue that came out of this discussion. We should consider to clean the statement descriptor values before saving them in the settings. That would increase confidence that the data would not make the intents fail and we would not have to clean every time we send them.

Acceptance criteria

Dev notes

See this Stripe's method as a reference – it should not be entirely copied because it probably doesn't match our needs.

Currently the validation is accepting values like " testing" without errors. In cases like that, we can either make the validation stricter – ideally it would be as strict as it requires, like not accepting any spaces – or trimming it before saving it, which I'd not recommend because that would require us to reflect that change in the UI.

@cesarcosta99 cesarcosta99 added type: enhancement The issue is a request for an enhancement. component: settings Issues related to Settings category: projects For any issues which are part of any project, including bugs, enhancements, etc. labels Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. component: settings Issues related to Settings focus: account lifecycle type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants