Reduce the props passed in for the image #117

ingeniumed · 2023-10-27T03:39:57Z

Description

Currently, the way the image props are built results in extra properties being set for the NextImage and the img. This results in warnings being published of unrecognized properties being set. So, this PR sets just the ones that should be necessary instead.

At the moment, that's just alt and src. Happy to add more if need be.

alecgeatches · 2023-11-02T21:34:57Z

components/Image/Image.tsx

@@ -47,7 +46,8 @@ export default function Image ( props: Props ) {
 	return (
 		<NextImage
 			loader={loader}
-			{...imageProps}


@ingeniumed Minor, but I noticed that we use the NextImage-specific property fill here on line 45:

vip-go-nextjs-skeleton/pages/media/index.tsx

Lines 42 to 47 in 6620e2a

<Image

alt={altText}

className={styles.image}

fill={true}

src={sourceUrl}

/>

which will get dropped by the changes. Is there a way to change things so Image still properly passes inner properties to NextImage?

Reduce the props passed in for the image

7774a7d

ingeniumed self-assigned this Oct 27, 2023

ingeniumed requested review from chriszarate and a team October 27, 2023 03:40

alecgeatches reviewed Nov 2, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce the props passed in for the image #117

Reduce the props passed in for the image #117

ingeniumed commented Oct 27, 2023

alecgeatches Nov 2, 2023

	<Image
	alt={altText}
	className={styles.image}
	fill={true}
	src={sourceUrl}
	/>

Reduce the props passed in for the image #117

Are you sure you want to change the base?

Reduce the props passed in for the image #117

Conversation

ingeniumed commented Oct 27, 2023

alecgeatches Nov 2, 2023

Choose a reason for hiding this comment