You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquisition scheme without b0 measurements should give warning that S0 must be estimated as parameter.
adds functionality to estimate S0 from data as extra parameter without b0 measurements.
S0 is always introduced as parameter instead of separate field that is passed. Added upon model instantiating with default cardinality 1 for 1 TE.
S0 cardinality, parameter ranges and scales are setup at beginning of fit(). cardinality is N for N TE values (1 if it is not given). range e.g. 0.5 of min value to 1.5 of max value. scale is set to mean of b0 (or S0 guess).
optimize_S0 boolean to either optimize S0 with parameters or fix it to the mean of b0 measurements.
if False, S0 is not even passed to the optimizer, but data is predivided inside optimization call but before actual optimizer.
if True, S0 is passed and data is divided by S0 inside each optimizer call (and expanded for multi-TE data).
if True and there are b0s, S0 initial guess is made to mean of b0 measurements.
if True and there are no b0s, S0 initial guess is made to gaussian fit of DWIs and estrapolated to b=0.
if False and there are b0s, S0 is fixed to mean of b0 measurements.
if False and there are no b0s, an appropriate error is given that tells to check the acquisition scheme or set optimize_S0=True.
if True and there are multiple TEs, NotImplemented error for now.
if False and there are multiple TEs, S0 is not a float but an array of cardinality the number of TEs. inside the optimization the S0s are expanded to become the length of the DWIs to divide them.
S0 estimation in MultiCompartmentModel
S0 estimation in MultiCompartmentSphericalMeanModel
S0 estimation in MultiCompartmentSphericalHarmonicsModel (S0 is at least calculated as parameter after the CSD optimization).
IVIM as custom_optimizer just as ss3t.
correct IVIM example
if optimize_S0=False, then S0 (and other fixed parameters) are passed as extra arguments to lbfgs minimizer (so not causing extra computation time).
update all predict functions in FittedCompartments
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes IVIM example #15
closes Option to estimate S0 during model fitting instead of pre-dividing by mean of b0s #18
closes Ability to easily set parameter optimization ranges #37