Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GetMediaSourceAsync to ICoreTrack #207

Open
Arlodotexe opened this issue Jul 25, 2022 · 1 comment
Open

Move GetMediaSourceAsync to ICoreTrack #207

Arlodotexe opened this issue Jul 25, 2022 · 1 comment
Assignees
Labels
breaking change cores refactor sdk Related to the Strix Music SDK
Milestone

Comments

@Arlodotexe
Copy link
Owner

Arlodotexe commented Jul 25, 2022

Background

GetMediaSourceConfig is currently sitting on ICore. You can easily access this method from pretty much anywhere. If you have an ICoreTrack, simply access track.SourceCore.GetMediaSourceAsync(track).

Problem

There's no explicit problem with this (yet), but there are a few advantages to changing it.

Solution

Move GetMediaSourceAsync to ICoreTrack and ITrack directly. This has a few immediate knock-on effects:

  • This method becomes part of the merging process for collection items.
    • Removes the ambiguity of "which source should I use", without restricting you to a single source.
  • PlaybackItem can be removed and replaced with ITrack.
  • On the core side, this puts the media source into the same context as the track, which reduces development complexity in several scenarios.
@Arlodotexe Arlodotexe added sdk Related to the Strix Music SDK cores refactor high difficulty Takes significant effort to complete needs community feedback Feedback from the broader community are requested enhancement New feature or request labels Jul 25, 2022
@Arlodotexe Arlodotexe removed enhancement New feature or request high difficulty Takes significant effort to complete needs community feedback Feedback from the broader community are requested labels Aug 16, 2022
@Arlodotexe Arlodotexe added this to the Road to 0.1.0 milestone Dec 27, 2022
@Arlodotexe Arlodotexe self-assigned this Jan 3, 2023
@Arlodotexe Arlodotexe removed this from the Road to 0.1.0 milestone Jan 3, 2023
@Arlodotexe
Copy link
Owner Author

This has been removed from the 0.1.0 milestone to allow us to polish and ship the update faster

@Arlodotexe Arlodotexe added this to the Road to 0.2.0 milestone Jan 3, 2023
@Arlodotexe Arlodotexe moved this to In Progress in Strix Music May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change cores refactor sdk Related to the Strix Music SDK
Projects
Status: In Progress
Development

No branches or pull requests

1 participant