Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE in MvpDelegate.onAttach in 1.5.5 #237

Open
asfdfdfd opened this issue Dec 13, 2018 · 4 comments
Open

NPE in MvpDelegate.onAttach in 1.5.5 #237

asfdfdfd opened this issue Dec 13, 2018 · 4 comments

Comments

@asfdfdfd
Copy link

asfdfdfd commented Dec 13, 2018

implementation "com.arello-mobile:moxy:1.5.5"
implementation "com.arello-mobile:moxy-android:1.5.5"
kapt "com.arello-mobile:moxy-compiler:1.5.5"

MvpAndroidXFragment is just Kotlin clone of MvpAppCompatFragment for AndroidX — https://gist.github.com/asfdfdfd/87552746c9182f6b7311f3d9ce6272a6, but this issue has appeared sometimes before migrating to Android X.

Here you could find shared Crashlytics record — http://crashes.to/s/d4ea6c01c8b

Also i'm attaching txt dump of this record to the issue — com.mirrorai.app_issue_1975_crash_5C1233CA02D700016492338D211553E3_DNE_1_v2.txt

I could not reproduce crash on my devices. It is super rare but i observe it from time to time.

@VovaStelmashchuk
Copy link
Contributor

Please provide your implementations of fragment and presenter.

@asfdfdfd
Copy link
Author

asfdfdfd commented Dec 14, 2018

Actually stack trace is not pointed to one of my fragments and presenters (except of MvpAndroidXFragment that is attached).

But it is pointed on androidx.fragment.app.FragmentStatePagerAdapter.

I have one FragmentStatePagerAdapter. Do you want implementation of Fragment/Presenter where adapter is placed or one of adapter's child or all children of adapter?

@alxgord
Copy link

alxgord commented Jan 3, 2019

Actually stack trace is not pointed to one of my fragments and presenters (except of MvpAndroidXFragment that is attached).

But is is pointed on androidx.fragment.app.FragmentStatePagerAdapter.

I have one FragmentStatePagerAdapter. Do you want implementation of Fragment/Presenter where adapter is placed or one of adapter's child or all children of adapter?

Do you trying to update adapter items? FragmentStatePagerAdapter have some old bug with tags of restored fragments https://issuetracker.google.com/issues/36956111. Maybe this will help you https://github.com/inloop/UpdatableFragmentStatePagerAdapter

@asfdfdfd
Copy link
Author

Do you trying to update adapter items?

No. I replace entire adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants