Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query for monitored function #90

Open
gomoripeti opened this issue Sep 29, 2017 · 2 comments
Open

Update query for monitored function #90

gomoripeti opened this issue Sep 29, 2017 · 2 comments

Comments

@gomoripeti
Copy link
Collaborator

Allow to update the query (in place in the graph title bar) for already monitored functions. This can be done without backend modification with a demonitor/monitor combo.
Some restrictions may apply such as only allow to modify the match-spec part and not module and function.
Some attention needs to be payed for error handling, eg if the new query is invalid keep the old graph unchanged.

@afronski
Copy link
Contributor

afronski commented Sep 29, 2017

In such case I think without additional marker on graph it may introduce confusion (e.g. vertical line that marked change in the query with before / after) - so we need to remember about that too in this task.

@gomoripeti
Copy link
Collaborator Author

True, I just had in mind (laziness) not to reenter the query and just clear the graph all together.
But good idea to keep old results but with a very much visible mark that from a certain point we are monitoring something completely different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants