Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simple table redesign #6831

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Nov 19, 2024

Feature Preview

  • revamp the UI
    • table action menu
    • table cell border
    • option menu
    • render the border when selecting column or row
  • re-implement the logic
    • drag to resize the cell width
      • don't persist data while dragging
      • persist the data after drag ends
    • redefine the simple table structure
    • insert left (column)
      • update the column map (align, color)
    • insert right (column)
      • update the column map (align, color)
    • insert above (row)
      • update the row map (align, color)
    • insert below (row)
      • update the row map (align, color)
    • duplicate
      • column
        • content
        • color
        • align
      • row
        • content
        • color
        • align
    • clear content
    • delete (row)
      • update the column map (align, color)
    • delete (column)
      • update the column map (align, color)
    • align
      • column
      • row
    • color
      • column
      • row
    • header column
      • background color
      • bold
    • header row
      • background color
      • bold
    • shortcuts
      • arrow up/down/left/right
      • tab
      • backspace
      • delete
  • tests
  • issues
    • a magic space between two cells
    Screenshot 2024-11-21 at 18 09 44 Screenshot 2024-11-21 at 22 06 34

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.06%. Comparing base (7ecf213) to head (1f230d0).
Report is 271 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6831      +/-   ##
==========================================
- Coverage   74.41%   65.06%   -9.36%     
==========================================
  Files         245      274      +29     
  Lines        6566    10599    +4033     
  Branches     1057     1424     +367     
==========================================
+ Hits         4886     6896    +2010     
- Misses       1628     3531    +1903     
- Partials       52      172     +120     
Flag Coverage Δ
appflowy_web_app 65.06% <ø> (-9.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant