-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring request for Study export function #1646
Labels
technical story
Technical story
Comments
TLAIDI
pushed a commit
that referenced
this issue
Jul 21, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 21, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 24, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 25, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 25, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 25, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 25, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 27, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 28, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 31, 2023
TLAIDI
pushed a commit
that referenced
this issue
Jul 31, 2023
TLAIDI
pushed a commit
that referenced
this issue
Aug 1, 2023
TLAIDI
pushed a commit
that referenced
this issue
Aug 1, 2023
TLAIDI
pushed a commit
that referenced
this issue
Aug 1, 2023
laurent-laporte-pro
changed the title
[tech] Refactoring request for Study export function
Refactoring request for Study export function
Aug 3, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
laurent-laporte-pro
pushed a commit
that referenced
this issue
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This ticket is a technical request in order to refactor the Study export function
export_study_flat
located in theantarest.study.storage.utils
package. The purpose of this function is to copy a Study to a destination directory with the simulation output (if this option is selected).The current implementation needs improvement in terms of code organization and responsibility separation. I believe the following changes will enhance the overall design and maintainability of the codebase.
Move the export function to the
antarest.study.storage.abstract_storage_service
module:Currently, the export function resides in the
utils
package. To align with the code structure and improve coherence, I propose relocating the function to theantarest.study.storage.abstract_storage_service
module.Separate file copying and matrix denormalization responsibilities:
The export function currently combines the tasks of file copying and matrix denormalization. It would be beneficial to separate these responsibilities.
Furthermore, I suggest implementing the denormalization directly within the two calling functions:
VariantStudyService.export_study_flat
andRawStudyService.export_study_flat
. This approach will distribute the responsibility more effectively.Tasks
export_study_flat
,VariantStudyService.export_study_flat
andRawStudyService.export_study_flat
are corectly tested.The text was updated successfully, but these errors were encountered: