Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Fixes - don't auto-build weekly, don't run duplicate jobs #15

Open
AngusP opened this issue Jun 14, 2024 · 0 comments
Open

CI Fixes - don't auto-build weekly, don't run duplicate jobs #15

AngusP opened this issue Jun 14, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AngusP
Copy link
Owner

AngusP commented Jun 14, 2024

  • I'm not sure we should rebuild the docker image on a schedule, it can break things unexpectedly without code or package changes, e.g. getting python error #13 and makes it seem like there's been an update when there hasn't.

  • Separatelty, some of the triggers for CI runs seemingly overlap so we run the same job twice/whatever (e.g. on Package Updates, downgrade to Py3.11 for Pydantic compatibility issue. Fixes #13 #14)

  • Also, we just check that the image starts up ok in CI. We're not running the same tests that just test does -- a separate test job would be good.

@AngusP AngusP added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant