Refactor: Refactor Experiment to Block in backend (and partly in frontend) #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drikusroor
force-pushed
the
refactor/1147-BE-rename-experiment-block
branch
from
0547bf0
to
8bcba05
Compare
BeritJanssen
reviewed
Jul 9, 2024
BeritJanssen
reviewed
Jul 9, 2024
drikusroor
force-pushed
the
refactor/1147-BE-rename-experiment-block
branch
from
8bcba05
to
cd59cc0
Compare
drikusroor
force-pushed
the
refactor/1147-BE-rename-experiment-block
branch
from
cd59cc0
to
f82cd8b
Compare
|
So far, I haven't found anything broken after this major refactor. Nice work! I did click a bit through the admin interface and found the following leftover references to experiment instead of block (in the custom templates for the ExperimentCollection "dashboard" view, as well as the inline template for setting question series for a block): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes refactoring the names of Experiment and GroupedExperiment to Block and GroupedBlock in the backend code. It also updates the frontend code to use the new names.
120 files changed... The backend tests & lints seem to succeed. Furthermore, I did some basic testing by going through my local Toontjehoger Experiment(Collection) and its Blocks (yes, Blocks) and found no problems. Perhaps it'd be a good idea if you did the same? Of course it's always a good idea to backup your local db just in case as the migrations are strong in this one.
Resolves #1147