-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: ExperimentCollection, ExperimentCollectionDashboard, Header, Score & Rank components #1140
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: frontend/src/components/ExperimentCollection/ExperimentCollection.tsx
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments on the ExperimentCollection/Score component. (If removing this component altogether is not feasible, renaming to Cup
or something similar might be clearer.) Other than that, looking good. Thanks!
0ff7be4
to
1392b84
Compare
…ctionDashboard and Header files
7995bdc
to
361d6a6
Compare
This pull request includes several refactors to improve the codebase and add unit tests for the Rank component. The changes include removing an unused variable, updating import paths, moving components to their own files, updating prop types, and converting components to use TypeScript. Additionally, unit tests have been added for the Rank component to ensure its functionality. These changes aim to improve code organization, maintainability, and test coverage.
Resolves #1139