Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: ExperimentCollection, ExperimentCollectionDashboard, Header, Score & Rank components #1140

Merged
merged 23 commits into from
Jun 28, 2024

Conversation

drikusroor
Copy link
Contributor

This pull request includes several refactors to improve the codebase and add unit tests for the Rank component. The changes include removing an unused variable, updating import paths, moving components to their own files, updating prop types, and converting components to use TypeScript. Additionally, unit tests have been added for the Rank component to ensure its functionality. These changes aim to improve code organization, maintainability, and test coverage.

Resolves #1139

Copy link

sentry-io bot commented Jun 19, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/components/ExperimentCollection/ExperimentCollection.tsx

Function Unhandled Issue
ExperimentCollection TypeError: null is not an object (evaluating 't.theme') ExperimentCollection(src/components/ExperimentCollection/ExperimentColl...
Event Count: 17 Affected Users: 3

Did you find this useful? React with a 👍 or 👎

@drikusroor drikusroor self-assigned this Jun 19, 2024
@drikusroor drikusroor requested a review from Evert-R June 19, 2024 10:31
Copy link
Collaborator

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments on the ExperimentCollection/Score component. (If removing this component altogether is not feasible, renaming to Cup or something similar might be clearer.) Other than that, looking good. Thanks!

@drikusroor drikusroor force-pushed the refactor/1139-collection-components branch from 0ff7be4 to 1392b84 Compare June 25, 2024 11:12
@drikusroor drikusroor force-pushed the refactor/1139-collection-components branch from 7995bdc to 361d6a6 Compare June 28, 2024 09:41
@drikusroor drikusroor merged commit fca85c1 into develop Jun 28, 2024
10 checks passed
@drikusroor drikusroor deleted the refactor/1139-collection-components branch June 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ExperimentCollection, Dashboard, Header & Score components
2 participants