You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This bit is in here for "historical reasons" - the Trial has a result_id at top level, but this is not necessary anymore. (Before a refactor, the "breaking round" mechanism was handled through this top level result id.) I checked, and indeed, no Trial in the current rules files contains a result_id. We should remove result_id from the backend Trial constructor and this condition here. (Can be left for later though.)
drikusroor
changed the title
Remove result_id from the backend Trial constructor and the if (result_id) condition in Trial.tsx.
Clean up (usage of) onResult, makeResult, and onNextSep 10, 2024
1. Remove
onNext
calls from theonResult
callback functionWe can probably just wait for
onResult
to finish and callonNext
manually (inmakeResult
)2. Remove
result_id
from the backendTrial
constructor and theif (result_id)
condition inTrial.tsx
.MUSCLE/frontend/src/components/Trial/Trial.tsx
Lines 76 to 83 in 00c3e63
Originally posted by @BeritJanssen in #1254 (comment)
UPDATE
Some work in progress can be found in #1258
The text was updated successfully, but these errors were encountered: