Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing IPdfFormatter #873

Open
bjosttveit opened this issue Oct 31, 2024 · 0 comments
Open

Consider removing IPdfFormatter #873

bjosttveit opened this issue Oct 31, 2024 · 0 comments
Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes
Milestone

Comments

@bjosttveit
Copy link
Member

IPdfFormatter was a feature primarily made for the old PDF generator, but was preserved to make migrating to the new one easier. The reason for using this, was mainly that dynamics did not run on the old PDF generator, so if you needed to dynamically hide components you had to implement the same show/hide logic for the PDF generator using IPdfFormatter. This is no longer an issue as this is covered out-of-the-box with expressions, but you could still use it for additional visibility logic if you want to do special things only in PDF.

The IPdfFormatter interface has already been marked as obsolete for a while.

Before deciding on whether to remove this feature or not we should check how it is used today for apps in v8. It is unfortunately not trivial to automatically migrate any logic from here.

@bjosttveit bjosttveit added this to the 9.0.0 milestone Oct 31, 2024
@bjosttveit bjosttveit added breaking-change Label Pull requests with breaking changes. Used when generating releasenotes and removed status/triage labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes
Projects
Status: No status
Development

No branches or pull requests

1 participant