Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add --version command to built binary #3447

Open
dylanschultzie opened this issue Nov 25, 2024 · 2 comments
Open

[Feature] Add --version command to built binary #3447

dylanschultzie opened this issue Nov 25, 2024 · 2 comments
Labels
feature New feature or request

Comments

@dylanschultzie
Copy link

🚀 Feature

Add --version to snarkos such that we can see what tag and git commit hash was used to build the binary.

Other networks version:

near:

$ neard -V
neard (release 2.3.1) (build 2.3.1) (rustc 1.81.0) (protocol 72) (db 40)
features: [default, json_rpc, rosetta_rpc]

solana:

$ solana --version
solana-cli 1.18.25 (src:92ddaa20; feat:3241752014, client:Agave)

cosmoshub:

$ gaiad version
release/v21.x-7c0c4cbb7b26c48b235f60532223a74f4f68b830

Motivation

This helps debug issues with builds to ensure binary is correct (doing sha256sum snarkos, as an example, isn't a good stand-in). It also helps automations to confirm the new build is the correct output.

Implementation

Are you willing to open a pull request? (See CONTRIBUTING)

@dylanschultzie dylanschultzie added the feature New feature or request label Nov 25, 2024
@mnguyen-io
Copy link

+1 please. Our automated build verification process would very much appreciate this feature.

@kim201212
Copy link

+1
I think this is a very necessary feature as we need to check the version of the built binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants