Factorio 2.0 changes for stdlib #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mods are storing any direction values in their storage, they will need to migrate them by multiplying by 2.
2.0 no longer allows assigning values to non-event handlers (1.1 tolerated it, 2.0 throws an error).
…es to LuaPrototypes::X.
hgschmie
force-pushed
the
factorio-2.0
branch
from
5c9e048
to
41c44ba
Compare
|
This looks good to me. I'd put up my own PR but only did what was necessary to get Nanobots working. I have no prior experience with Factorio modding so I'm happy to support this PR. |
| _G.script[name] = function() | ||
| error('Detected attempt to register an event using script.' .. name .. ' while using the STDLIB event system ') | ||
| end | ||
| end |
There was a problem hiding this comment.
I deleted this as well. Not sure how to otherwise fix it.
from the 2.0.7 changelog: * Type of LuaObjects is now "userdata" instead of "table". * Removed __self from the LuaObjects. Intended way of checking if an object is a lua object is to check type is userdata. Without this change, e.g. Is.Valid does not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalintostorage.