Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Complete planet.csv file #106

Open
aaronjridley opened this issue May 12, 2023 · 1 comment
Open

[FEAT] Complete planet.csv file #106

aaronjridley opened this issue May 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@aaronjridley
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For every planet, there needs to be a relationship between the longitude and the local time. These are related through the length of a day, the time, and a reference longitude. The reference longitude is the longitude which was at midnight local time on January 1, 2000 at 00 UT. Given these quantities, the local time can be calculated for any time.

At this point, there is column in the planet file for the reference longitude, but it is wrong for all of the planets except for Earth. This needs to be fixed and tests should be made for each planet.

Describe the solution you'd like

  1. research the reference longitudes for each planet and add into the planets file.
  2. create tests for a few planets to verify that they all work ok.

Describe alternatives you've considered
I am not entirely certain where to find this information. So, we need to do a bunch of research on this.

@aaronjridley aaronjridley added the enhancement New feature or request label May 12, 2023
@aaronjridley
Copy link
Contributor Author

From my understanding, the longitude of several gas giant planets doesn't really matter. Tests should still be created for each planet, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant