Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 Error - 'Allowed memory size of 134217728 bytes exhausted' in apache error log #108

Open
m3w88 opened this issue Nov 10, 2022 · 8 comments
Labels
bug Something isn't working in progress This is being worked on Priority: High

Comments

@m3w88
Copy link

m3w88 commented Nov 10, 2022

HM100,

Enabling this skin is causing the following severe PHP memory issues that impact an account from logging in correctly.
Environment: MediaWiki 1.37.6 is installed with PHP 7.4.3
Apache error logs: [Thu Nov 10 03:10:07.327876 2022] [php7:error] [pid 6684] [client IP:53222] PHP Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 61440 bytes) in /var/www/html/w/vendor/zordius/lightncandy/src/Validator.php on line 39

lightncandy is An extremely fast PHP implementation of handlebars ( http://handlebarsjs.com/ ) and mustache ( http://mustache.github.io/ ).

Disabling the Skin resolved issues.

@HM100
Copy link
Member

HM100 commented Nov 12, 2022

For now, increase the amount of RAM until you resolve the issues. This will be difficult to be resolved without reducing performance.

@HM100 HM100 added bug Something isn't working Priority: High labels Nov 12, 2022
@HM100 HM100 pinned this issue Nov 12, 2022
@HM100
Copy link
Member

HM100 commented Nov 14, 2022

But yeah this issue is more apparent on devices with fewer RAM. This needs certain code to be moved to PHP code, however, if code that it is shared between this repo and this one is also required to be in PHP, it will be done but only for the Evelution Skin as the CPE Language core GitHub Repo does not support PHP

@HM100
Copy link
Member

HM100 commented Dec 1, 2022

For the fix, I will move into PHP what I can do. Using some code from the Cosmos skin as a base will be a good start. But this will result in a major release being released as I will move such classes from <container> to <body>

@HM100
Copy link
Member

HM100 commented Dec 1, 2022

The next update will trade some Mustache code with PHP ones

@HM100
Copy link
Member

HM100 commented Dec 1, 2022

Evelution 126.0.0 contains certain changes to some Mustache code, improving performance in some cases

@HM100 HM100 added the in progress This is being worked on label Dec 1, 2022
@HM100
Copy link
Member

HM100 commented Dec 1, 2022

In progress as Evelution 126.0.0 did some of the part

@HM100
Copy link
Member

HM100 commented Dec 20, 2022

Evelution 127.0.0 did more work, including moving the DPL Forum link into a new place and uses CSS to show/hide the link instead of conditional mustache code. One of the major changes in 127.0.0 is the merge of the two Community Links files into one.

@HM100
Copy link
Member

HM100 commented Feb 15, 2023

More Mustache code is being cleaned up as well, 131.0.0 did even more. For instance, some more CSS (Both inline and regular) in Mustache files has been migrated to CPE.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress This is being worked on Priority: High
Projects
None yet
Development

No branches or pull requests

2 participants